meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

Update PluginDataParam type definitions to include text label and pro… #3266

Closed veeting closed 1 year ago

veeting commented 1 year ago

We have identified that PluginDataParam has a few missing type definitions in janus.d.ts

NOTE:

janus.js is either using text or data which is confusing. The html demos are only referring to text. Thus, we have decided to not add data and add text as optional to avoid breaking any other app.

lminiero commented 1 year ago

janus.js is either using text or data which is confusing. The html demos are only referring to text. Thus, we have decided to not add data and add text as optional to avoid breaking any other app.

I'd rather both are kept in there, with the idea only data will remain someday. text is legacy from when we only supported text data, which is not the case anymore: we support binary data too. The fact that demos only refer to that is simply a conseguence of those legacy assumptions.

lminiero commented 1 year ago

Thanks for the fix, merging!