search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.25k stars 2.48k forks source link

Update versions of external css and js resources #3279

Closed bkmgit closed 11 months ago

lminiero commented 1 year ago

Sorry for the late feedback. This PR is not only updating the versions, it's changing the source of those JS files as well, which I personally don't like and don't want to go through. Any reason why you did that?

bkmgit commented 1 year ago

The second source also publishes hashes. But can calculate these using https://www.srihash.org/ Described at: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity If updating version is ok, can change source back to what it was.

lminiero commented 1 year ago

If updating version is ok, can change source back to what it was.

For the time being I'd prefer that, yes. The change of source is something that can be discussed in a separate PR.

That said, I'm not sure how safe updating jQuery is, especially when building the documentation, as I don't know if there's things Doxygen relies upon that may be affected by breaking changes.

You're also updating the version of Bootstrap to 5.x, which is wrong. Bootstrap 5 is completely incompatible with the templates we use, which uses Bootstrap 3. A few times I've tried working on upgrading our demos to Bootstrap 4 or 5, and always failed miserably, because there's too much to change and I always got stuck in some places.

Please make sure to only submit commits that upgrade versions that you've explicitly tested yourself, for all demos.

lminiero commented 1 year ago

@bkmgit any update on this? Thanks!

bkmgit commented 1 year ago

Thanks for your comments. Sorry for the delay. Will check with a deployment.

bkmgit commented 11 months ago

Yes you are correct, documentation does not build and pages do not render correctly.

bkmgit commented 11 months ago

Closing in favor of https://github.com/meetecho/janus-gateway/pull/3295