meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

Remove .nfo file provisioning in auviousrecordplay Plugin #3330

Closed anger232 closed 7 months ago

anger232 commented 7 months ago

Removed all .nfo file provisioning in auviousrecordplay plugin. Recording metadata in auvious is handled by recorder service so we do not need this logic. Also with many recordings over time this would lead to unnecessary memory usage and could also lead to erroneous behaviour, which could occur if the janus container was restarted, since it would attempt to load all previous .nfo files and associated recording files.

januscla commented 7 months ago

Thanks for your contribution, @anger232! Please make sure you sign our CLA, as it's a required step before we can merge this.

lminiero commented 7 months ago

Created a PR against the wrong repo, huh? 🤭

anger232 commented 7 months ago

Yes sincere apologies!