meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

Add unauthenticated no-payload ping endpoint for health checks #3336

Closed husam212 closed 7 months ago

husam212 commented 7 months ago

The current admin ping request is unauthenticated, but it requires a JSON payload, it's not possible to add a payload to health checks in most web servers (for example Caddy and Nginx) and DNS services (for example Route53 and Cloudflare). This makes it hard to implement auto-failover using reverse proxy or DNS service, it would be useful to have a dedicated URI /ping for health checks that doesn't require a payload.

lminiero commented 7 months ago

That's a good suggestion, thanks! I'll see if that can be added to the HTTP transport.

lminiero commented 7 months ago

Implemented in the commit above for both Janus and Admin APIs.

husam212 commented 7 months ago

Thanks! That was quick.