search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
7.98k stars 2.45k forks source link

[1.x] Crash / segfault on 1.2.2 #3354

Closed tespio closed 2 months ago

tespio commented 2 months ago

What version of Janus is this happening on? Janus version: 1202 (1.2.2) Janus commit: #3346

Have you tested a more recent version of Janus too? No. Since March 22 when i've compiled this commit with libasan it just crashed today.

Was this working before? Well, intermittently, mostly yes, but since we started using 1.2.1 had several segfaults (as reported HERE on March 22)

Is there a gdb or libasan trace of the issue? https://gist.github.com/tespio/1ffdc026c90bc2337b84492b656cf626

Additional context It seems like I have more or less the same asan dump like the one mentioned on discourse HERE

atoppi commented 2 months ago

@tespio @RSATom please test #3355

tespio commented 2 months ago

I've recompiled with the #3355 but it may take a while until I can come back with some observations, if any. (hopefully if it doesn't crash anymore so there won't be any observation to be made :) )

tespio commented 2 months ago

Okay, here we go again @atoppi. It took a while but it crashed again.

https://gist.github.com/tespio/4ac1473acb77cc7a0c8cda3ed9834a5d

atoppi commented 2 months ago

@tespio this one looks different. A destroy room request has freed a room that was being accessed while handling a RTP packet of one of the participants. Please open a new issue.

If the previous crash is not happening anymore we'll close this one and merge the proposed patch.

tespio commented 2 months ago

@tespio this one looks different. A destroy room request has freed a room that was being accessed while handling a RTP packet of one of the participants. Please open a new issue.

If the previous crash is not happening anymore we'll close this one and merge the proposed patch.

Okay @atoppi. I will open a new issue with the same gist. Thank you.