search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

[1.x] videoroom: support of string_ids/string_ids_user #3364

Open IgorKhomenko opened 5 months ago

IgorKhomenko commented 5 months ago

This is more a feature request rather than an issue.

There is a case when integrate Janus with 3rd party system where room id is a string, but user id is a number.

With current version of Janus, it's only possible to have ether string or number for both.

It would be very useful to have a way to configure it separately, e.g. to set string_ids = TRUE; and to have a separate variable for users: string_ids_user = FALSE; https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L1951

I already have a custom branch with this change and wondering is it something you are interested in to have, so I could do a PR.

Thank you in advance

amnonbb commented 5 months ago

In our case we need change for users string but leave rooms with number. Is it possible in your branch?

IgorKhomenko commented 4 months ago

@amnonbb here is a PR https://github.com/meetecho/janus-gateway/pull/3369