search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

[1.x] Commandline option "--version" no longer exists #3383

Closed fancycode closed 4 months ago

fancycode commented 4 months ago

What version of Janus is this happening on?

Janus version: 1203 (1.2.3)
Janus commit: bc044995a94c623b747bb35ecb9f059190903803

Have you tested a more recent version of Janus too? no

Was this working before? This is working with the 0.x branch.

Additional context Looks like this got removed by the migration away from gengetopt which added a handler for --version automatically.

We used this on our build systems as a simple check to see if all dependencies are available, so it would be great if this could be re-added. I'll check if I find some time the next days to prepare a PR myself.

lminiero commented 4 months ago

Looks like this got removed by the migration away from gengetopt

Yeah, this is very likely: in 1.x we create the options programmatically with GLib (GoptionEntry), which does generate a helper automatically (-h) but it doesn't indeed expose a version too as we did before. This should be added to options.c/.h. I'm out of office the next few days but I'll look into it when I'm back.