search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

SIP plugin: add logger callback function for processing SIP message traces in a single log callback for Sofia >= 1.13 #3386

Closed ycherniavskyi closed 2 months ago

ycherniavskyi commented 4 months ago

Fixes #3365.

lminiero commented 3 months ago

Thanks for reviving this! I'll review in the next few days and get back to you :+1: Have you tested this with both 1.12 and 1.13?

ycherniavskyi commented 3 months ago

I've specifically tested on version 1.13. And in current implementation logic for version 1.12 was not changed at all.

lminiero commented 3 months ago

@ycherniavskyi were you waiting for more feedback from me, or have all notes been addressed in the commits that followed?

ycherniavskyi commented 3 months ago

@lminiero I've addressed all your comments except for the one about dropping OPTIONS, which we decided to leave (assuming I understood you correctly). Therefore, from my perspective, this PR is ready to merge! 😊

lminiero commented 2 months ago

Thanks, merging then! I'll also backport this to 0.x :+1: