search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.25k stars 2.48k forks source link

PLI dilution (Multistream) #3423

Open natikaltura opened 2 months ago

natikaltura commented 2 months ago

Implementation of PR #3422 (https://github.com/meetecho/janus-gateway/pull/3422) for multi-stream

Would love to get your input. Nati Baratz

natikaltura commented 1 week ago

Hi @lminiero,

I had some git issues so sorry for the mess. Fixed the 2 PR’s.

Reopening the code for this PR.

Thanks

lminiero commented 4 days ago

Your PR still includes the changes to the management of simulcast, which has nothing to do with the main purpose of the patch. I already explained that you can already configure the behaviour per subscriber using the API, and that publisher based APIs for framerate can be done in future efforts.

natikaltura commented 3 days ago

@lminiero I'm a bit confused :) The changes doesn’t alter any functionality related to simulcast management. I believe what you're referring to is the log in rtp.c, which simply adds an additional field (Milliseconds) to the log. I find this addition very helpful for tracing PLI handling. Cheers

natikaltura commented 2 days ago

"Hi @lminiero, thanks for your comments! All fixed and pushed.

natikaltura commented 2 days ago

@lminiero, done, thanks! I believe next time will go smoother! :)

natikaltura commented 2 days ago

@lminiero, fixed..