search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

Add display property on leave or unpublish event #3426

Open amnonbb opened 1 week ago

amnonbb commented 1 week ago

As title say. If it's not doing problem somewhere it's help to get display property in event as it's done in other places.

atoppi commented 1 week ago

Just to double check since it is not being mentioned: this is for the kicked / unpublished / leaving event emitted to the event handlers, so unrelated to the Janus API event.

lminiero commented 1 week ago

Good catch: is that what you meant to do @amnonbb?

amnonbb commented 1 week ago

Good catch: is that what you meant to do @amnonbb?

Yes. it is. Almost in all places we got display property except kicked / unpublished / leaving

amnonbb commented 1 week ago

Just to double check since it is not being mentioned: this is for the kicked / unpublished / leaving event emitted to the event handlers, so unrelated to the Janus API event.

Sorry, now i understood what you ask. Event handlers is where i used it and keep fork only for this change. But generally may be right to add it in Janus API event as well.

lminiero commented 5 days ago

@amnonbb looks good to me! Could you also update the documentation of the impacted events, though, to clarify there could be a display property too now?