search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.22k stars 2.48k forks source link

[1.x] Segmentation Fault on janus_recordplay_playout_thread #3445

Open Loki899899 opened 3 weeks ago

Loki899899 commented 3 weeks ago

What version of Janus is this happening on? "version": 1104, "version_string": "1.1.4", "commit-hash": "cce3f2399830a1f62116af9eb08821ae63bda0f0",

Have you tested a more recent version of Janus too? No, currently I'm not able to(won't be for a while), I'll update results accordingly once I test the latest version.

Was this working before? First time encountering this. Earlier version didn't seem to have this problem

Is there a gdb or libasan trace of the issue? Please find the GDB trace here.

Additional context System: CentOS Stream release 8 Please let me know if any other details are needed.

lminiero commented 3 weeks ago

1.1.4 is a year and a old half: I most definitely recommend upgrading. That said, your gdb trace doesn't seem to provide ny useful info, as the line it points to can't possibly crash (it's a simply math on number variables). The only recent fix we made to Record&Play that could cause a crash is https://github.com/meetecho/janus-gateway/commit/bad60d7032026af453a98ed7aba7fbc083385ea2 so when you upgrade you should be able to confirm whether that was the actual cause of yours too. Before submitting new reports, please considering building with libasan support which will give better info on the causes of a crash.

Loki899899 commented 3 weeks ago

I'll definitely be upgrading Sorry the trace wasn't helpful (math, I thought the same, I did try to check the values the ts_diff seemed null and the line above it seemed to have no value for video->prev I thought that could be something), not good at C. Also while building next time I'll surely try to do it with libasan. Thanks for the quick reply