search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.23k stars 2.48k forks source link

SIGSEGV on unknown address (in janus_ice_webrtc_free) #615

Closed cacheworks closed 8 years ago

cacheworks commented 8 years ago

Hello,

Sorry for all these issues in a row, just want to make sure to document the different crashes separately as I didn't think it's directly related to any other open issue

Here's the AddressSanitizer output; https://gist.github.com/cacheworks/a32202d1aeb3fe5897c78115e94c65ac

Since it refers to janus_ice_webrtc_free in ice.c:1168 which has been changed in the refcount branch I will try that branch on the production server and see if this still pops up

I got this with the same build as #613 (commit 0d537c71e94c603c650a89740b7d7ae89c20e47b)

Thanks in advance for your help again!

lminiero commented 8 years ago

Doesn't seem to provide enough info, sorry. It only tells it crashed somewhere but not as a consequence of what. It may simply be a race condition with a handle already freed by the watchdog and for some reason still accessed by one of the threads. The reference counters branch would prevent that from ever happening.

cacheworks commented 8 years ago

Thanks for having a look, I'll close this for now and will start testing the refcount branch instead since that seems to be aimed towards fixing most of these issues already :+1: