search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.23k stars 2.48k forks source link

Uncaught TypeError: r.slowLink is not a function #733

Closed jasonblais closed 7 years ago

jasonblais commented 7 years ago

Background

Mattermost uses this Janus server as a WebRTC gateway for a preview feature of audio and video calls. We're using the official janus javascript library to create the sessions and establishing the webrtc connection between the peers, with limited changes.

Things have been working fine until updating to the latest Janus server earlier this week. Since then, we've received continuous Uncaught TypeError: r.slowLink is not a function JavaScript errors during a call.

Would you have any hints why these errors might be occurring, and how to fix them?

PS: There are also some issues with audio and video, but we're investigating whether those issues are on our end. Also began after the latest server update.

lminiero commented 7 years ago

Is your janus.js up to date? This was addressed and fixed in #710

jasonblais commented 7 years ago

We used version 0.21, your latest release. Are you planning to do a new release soon, or should we use your master branch instead?

lminiero commented 7 years ago

Using the latest janus.js should be enough, no need to update to master the rest of the code.

jasonblais commented 7 years ago

Okay, we'll try that. Thanks @lminiero!

lminiero commented 7 years ago

Closing since, as discussed, it should have been fixed for some time already. Feel free to reopen if that's not the case.

jasonblais commented 7 years ago

Sorry @lminiero, forgot to come back --> the issue is indeed fixed, thank you!

karthik-aiyer-fujixerox commented 7 years ago

@lminiero you mentioned we need to get the "latest" janus.js.

Correct me if I'm wrong, isn't the janus.js in 0.2.1 the latest? I see you have answered this same question earlier but i don't find the "slowLink" callback handled in the 0.2.1 tag. It seems to be present in master, but then the master code for janus.js is not adding adapter.js atall and hence all the references of "adapter" object are failing!

lminiero commented 7 years ago

No, by latest I always mean master.

lminiero commented 7 years ago

The adapter is now imported in the html file.