meetecho / simple-whip-client

Simple WHIP Client (based on GStreamer's webrtcbin)
GNU General Public License v3.0
66 stars 18 forks source link

Added option to disable trickle, and send candidates in the SDP #7

Closed lminiero closed 2 years ago

lminiero commented 2 years ago

As the subject says, this PR adds a "no-trickle" mode: when enabled, the WHIP client will not trickle candidates via PATCH (default behaviour), but will wait for the gathering to complete to then add all candidates to the SDP offer instead. This shouldn't be needed even for servers that don't support trickle, as prflx candidates should still manage to get things working, but it's good to have the option anyway.

lminiero commented 2 years ago

Merging.