meetecho / simple-whip-server

Simple WHIP Server (based on the Janus WebRTC Server)
GNU General Public License v3.0
93 stars 24 forks source link

Fix mid-check condition for video forwarding #9

Closed redoPop closed 1 year ago

redoPop commented 1 year ago

This PR fixes an error in the multistream/forwarding behavior that caused it to stop processing the offer SDP before finding a video mid.

The condition was intended to break the loop once both an audio and video mid are found, since no more SDP lines need to be processed. Instead, it broke prematurely, after finding only an audio mid.

lminiero commented 1 year ago

Good catch, thanks! Merging :+1: