[Deploy] Telegram Dark Theme

meetfranz / plugins

Official Franz Plugin Repository

MIT License

298 stars 110 forks source link

[Deploy] Telegram Dark Theme #4

Open ldrrp opened 7 years ago

ldrrp commented 7 years ago

Service

Link to your repository

https://github.com/SiloCityLabs/recipe-franz-telegram-dark

adlk commented 7 years ago

Thanks for your plugin! I'm not going to deploy this right now as it would be a service duplicate. Instead I'm waiting for the settings API to be finished to merge your plugin with the existing one. . This allows us to add a setting to enable/disable the dark mode.

ldrrp commented 7 years ago

Yea i though about that afterward, i will be creating a pull request into your main recipe and adding a toggle into the menu by injecting js/css, how would that sound?

adlk commented 7 years ago

As long as it's not too intrusive it would be a great quick fix.

adlk commented 7 years ago

While you are at it, can you please take a look at this issue as well https://github.com/meetfranz/recipe-telegram/issues/1

I believe it should be fixed by adding a simple media query.

ldrrp commented 7 years ago

Sure thing

ldrrp commented 7 years ago

It seems I have similar issues with most services, I was gonna run through them all afterwards and fix their sizing issues. I like my chat clients to be small windows out of the way

ldrrp commented 7 years ago

I have created a toggle and pull request. https://github.com/meetfranz/recipe-telegram/pull/2

adlk commented 7 years ago

@ldrrp I'm getting a TypeError that is caused by adding the toggle.