search

meetfranz / recipe-skype

Official Franz Recipe for Skype
4 stars 7 forks source link

Cannot "make as read" Skype messages after someone push emoticon comment to message #11

Open haraldox opened 6 years ago

haraldox commented 6 years ago

originally posted to Franz main repo by @skibsky

Expected Behavior

After reading messages or click on left side "make all as read" notification about new message should dissapear

Current Behavior

After someone click on emoticon to comment message, new notification appear and can't be read at all (even after "make all as read" notification still appears)

Screenshots (if appropriate):

skype_notification_issue

Steps to Reproduce (for bugs)

  1. Get emoticon comment by other Skype user on message in conversation

Your Environment

StShadow commented 6 years ago

Same with Franz 5.0.0-beta.17.607 and MacOs Sierra 10.12.6

reconman commented 6 years ago

Whoever wants an urgent fix: Go to %appdata%\Franz\recipes\skype if you're on Windows and add my change.

reconman commented 6 years ago

Ignore the old commits, take the one from the pull request.

reconman commented 5 years ago

This issue was fixed by https://github.com/meetfranz/recipe-skype/commit/801fd15c0353569c06f496aa981bfd302306d084 and can be closed