search

meetfranz / recipe-skype

Official Franz Recipe for Skype
4 stars 7 forks source link

Skype serviceURL updated! #16

Closed omergulen closed 2 years ago

omergulen commented 5 years ago

15

molszews commented 5 years ago

it is still in preview, however, if someone wants to get a message counter then the count evaluation in webview.js should look more like: const count = document.evaluate("sum(//div[@role='tablist']//div[@data-text-as-pseudo-element=number(@data-text-as-pseudo-element)]/@data-text-as-pseudo-element)", document, null, XPathResult.NUMBER_TYPE, null).numberValue;

omergulen commented 5 years ago

I didn't get what you mean, or did you understand what I wanted to change and why?

omergulen commented 5 years ago

Still waiting for merge.

closingin commented 5 years ago

I don't think this will ever be merged. Why would we put in production a service that points to a preview version of an app ? Because it's a preview, it will constantly change and might break often its Franz integration, whereas the current one is stable.

Just wait for this preview to go live ?

omergulen commented 5 years ago

Got it now. I was thinking Franz should provide a new feature to users faster, and instantly that's why I thought would be great but as you said it may not be stable. But is there any chance that Franz can still support this Preview Skype for Web? As a spare service?

closingin commented 5 years ago

Maybe in the future, I'd imagine a service setting where you would check a box to enable the preview version !

omergulen commented 5 years ago

Or maybe even better you can add your own service? I mean from scratch xd