search

meetfranz / recipe-skype

Official Franz Recipe for Skype
4 stars 7 forks source link

Skype shows notification symbol for reaction-emojis #21

Closed jercypackson closed 5 years ago

jercypackson commented 6 years ago

Expected Behavior

Emoji reactions to messages should not count as new message, or at least the notification should dissapear when it's been opened.

Current Behavior

There's a (1) for a reaction to a message, that doesn't vanish until it's too "old" so it won't load anymore.

Screenshots (if appropriate):

bildschirmfoto 2018-04-05 um 11 08 57 kopie

Possible Solution

Only check for the skype sidebar for new messages, not the converations itself.

Steps to Reproduce (for bugs)

  1. Add an reaction to any message in any chat from an "official" app
  2. Done

Context

It's annyoing because there is no new message!

Your Environment

reconman commented 6 years ago

Can confirm the bug.

zanvd commented 6 years ago

Confirmed on Linux as well.

reconman commented 6 years ago

See https://github.com/meetfranz/recipe-skype/pull/13 for a fix

zanvd commented 6 years ago

Great, thank you. @adlk any chance his PR is going to be accepted and released in the near future?

dawidgora-old-account commented 5 years ago

Confirmed on Linux Debian 9 with GNOME

reconman commented 5 years ago

This issue was fixed by https://github.com/meetfranz/recipe-skype/commit/801fd15c0353569c06f496aa981bfd302306d084 and can be closed