search

meetfranz / recipe-skype

Official Franz Recipe for Skype
4 stars 7 forks source link

Skype keeps having (1) badge #6

Open ygrange opened 6 years ago

ygrange commented 6 years ago

On mac, using Franz Version 5.0.0-beta.14 (5.0.0-beta.14.451) having a Skype account. The Skype account almost constantly has a (1) badge while there are no unread messages. I really don't know how to solve this and whether this is an issue with the Skype recipe or with Skype itself but I figured reporting it would at least answer that question.

weierophinney commented 6 years ago

I can confirm.

Typically, I've found that when this happens, if I go into the skype client on my android tablet, I'll discover that I've got a notification about somebody's birthday, or somebody posted a reaction to a message I wrote. These do not seem to show up in the web client at all — which both Franz and the Linux client wrap — meaning you cannot dismiss them manually from those locations.

It's possible that the counter could potentially inspect the parent element to determine if the item should be counted. From what I can tell, the parent of a .counter item for a reaction is .reactionItem; perhaps those could be filtered out before issuing a count? (Not sure about birthdays, though; have not had one appear recently to inspect.)

reconman commented 6 years ago

Whoever wants an urgent fix: Go to %appdata%\Franz\recipes\skype if you're on Windows and add my change.

reconman commented 6 years ago

Ignore the old commits, take the one from the pull request.

synapsics-sergiu commented 6 years ago

For Linux: ~/.config/Franz/recipes/skype

reconman commented 5 years ago

This issue was fixed by https://github.com/meetfranz/recipe-skype/commit/801fd15c0353569c06f496aa981bfd302306d084 and can be closed