search

meetfranz / recipe-telegram

Official Franz Recipe for Telegram
4 stars 12 forks source link

Should `hasDirectMessages` be `hasIndirectMessages`? #15

Open bittner opened 4 years ago

bittner commented 4 years ago

I see in package.json that you use the hasDirectMessages flag.

Interestingly, the documentation doesn't mention that flag. Instead, it mentions a flag with the reverse logic:

boolean hasIndirectMessages default: false

Is this a bug? And, is the documentation wrong or the implementation in the JSON file?

I may have seem this implementation in other recipes as well.

hongshaoyang commented 4 years ago

Seems that it's a leftover configuration that was removed or modified:

https://github.com/meetfranz/franz/search?q=hasdirectmessages&unscoped_q=hasdirectmessages