Column widths in weekly view have changed to variable width.

[jberanek]

After upgrading from MRBS 1.4.8 to MRBS 1.5.0 the column widths in the weekly view have changed to be variable, and fairly randomly so.

Is there any way of returning this to fixed width?

Reported by: *anonymous

Original Ticket: mrbs/support-requests/951

Attachments: https://sourceforge.net/p/mrbs/support-requests/951/attachment/Variable.JPG

[jberanek]

Fixed width screenshot.

Original comment by: *anonymous

Attachments: https://sourceforge.net/p/mrbs/support-requests/_discuss/thread/d51ec541/bd3c/attachment/Fixed.JPG

[jberanek]

What browser and version are you seeing this in?

Original comment by: campbell-m

[jberanek]

IE 11 Chrome 49

Original comment by: *anonymous

[jberanek]

Copyed mrbs.css.php and style.inc from old version to new and away we go.

Original comment by: *anonymous

[jberanek]

Mmmm... Not sure why that should be so. I'll investigate.

Original comment by: campbell-m

[jberanek]

Ah, OK, I see what you mean. I assume that in the examples above you have a booking with a name that includes a word longer than the width of a column? I haven't had a chance to look yet at how MRBS used to handle this. Can you let me know what it did? Did it break the word?

You can fix the latest version of MRBS by adding a custom CSS rule (see systemdefaults.inc.php for how to define custom CSS):

.dwm_main a {
  word-wrap: break-word;
  word-break: break-all;
}

Alternatively you can modify the mrbs.css.php file. Either way, I recommend that you restore the latest mrbs.css.php and style.inc files otherwise you are likely to run into other problems.

I have now fixed this in the default branch (changeset 419e5688ff9e).

Original comment by: campbell-m

[jberanek]

Adding this did nothing to the table. Its not the face that the words are longer than the column. The black is the lenth of the text.

Original comment by: *anonymous

[jberanek]

Did you reinstate the new mrbs.css.php and style.inc?

Original comment by: campbell-m

[jberanek]

yes, fresh install.

systemdefaults.inc.php

$custom_css_url = 'css/custom.css';

custom.css

.dwm_main a { word-wrap: break-word; word-break: break-all; }

Original comment by: *anonymous

[jberanek]

Looks like there's a bug in 1.5.0 which has already been fixed in the default branch. Change line 1243 of functions_table.inc from

        $header_inner .= '<th data-date="' . $date . '" style="width: ' . $column_width . '%>' .

to

        $header_inner .= '<th data-date="' . $date . '" style="width: ' . $column_width . '%">' .

There was a missing double quotes character.

Original comment by: campbell-m

[jberanek]

Ingoring the modification before, editing a fresh install. this works prefectly!

Thank you :)

Original comment by: *anonymous

[jberanek]

The modification before actually fixes a different problem. It's probably worth keeping it in.

Original comment by: campbell-m

[jberanek]

What problem was that? i couldent see any difference?

Original comment by: *anonymous

[jberanek]

You'll only see a difference if you have a very long word in the brief description.

Original comment by: campbell-m

[jberanek]

The correct CSS is probably:

/* Ensure short words don't get broken in half */
/* but really long words will. */
.even_row a
{
  word-wrap: break-word;
  word-break: normal;
}
.odd_row a
{
  word-wrap: normal;
  word-break: break-all;
}

This doesn't allow short words to break in half, but it does allow really long words to break in half. See the screen shot. Most words format well, but the long word is forced to truncate.

Original comment by: xandrani

Attachments: https://sourceforge.net/p/mrbs/support-requests/_discuss/thread/d51ec541/8bfd/attachment/Screen%20Shot%202017-03-15%20at%2003.26.47.png

[jberanek]

I don't think that CSS works. The best I can come up with so far is

.dwm_main a {
  display: block;
  min-height: inherit;
  word-break: break-all;
  word-break: break-word;  /* Better for those browsers, eg webkit, that support it */
  hyphens: auto;
}

which works for WebKit browsers, but will still have short words breaking on other browsers.

See also Support Request 1200.

Original comment by: campbell-m

[jberanek]

Hi Campbell

I tested my CSS on Chrome, Firefox and Safari. However like you say, maybe it doesn't work on other browsers! I didn't have my Windows laptop to hand at the time.

Is this any use? https://justmarkup.com/log/2015/07/dealing-with-long-words-in-css/

https://justmarkup.com/log/2015/07/dealing-with-long-words-in-css/ Mike

On 21 March 2017 at 10:54, Campbell Morrison cimorrison@users.sf.net wrote:

I don't think that CSS works. The best I can come up with so far is

.dwm_main a { display: block; min-height: inherit; word-break: break-all; word-break: break-word; / Better for those browsers, eg webkit, that support it / hyphens: auto;}

which works for WebKit browsers, but will still have short words breaking on other browsers.

See also Support Request 1200 https://sourceforge.net/p/mrbs/support-requests/1200/.

• [support-requests:#951] https://sourceforge.net/p/mrbs/support-requests/951/ Column widths in weekly view have changed to variable width.*

Status: open Group: Created: Tue Apr 19, 2016 02:04 AM UTC by Anonymous Last Updated: Wed Mar 15, 2017 03:28 AM UTC Owner: nobody Attachments:

• Variable.JPG https://sourceforge.net/p/mrbs/support-requests/951/attachment/Variable.JPG (21.1 kB; image/jpeg)

After upgrading from MRBS 1.4.8 to MRBS 1.5.0 the column widths in the weekly view have changed to be variable, and fairly randomly so.

Is there any way of returning this to fixed width?

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/mrbs/support-requests/951/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

Original comment by: xandrani

Attachments: https://sourceforge.net/p/mrbs/support-requests/_discuss/thread/d51ec541/ec3d/2b16/attachment/alternate