search

meeting-room-booking-system / mrbs-code

MRBS application code
Other
127 stars 63 forks source link

No link under "view day" in week view #1856

Open jberanek opened 7 years ago

jberanek commented 7 years ago

Hi, have been updating an MRBS 1.2 to MRBS 1.5 for a customer and now we found that there is no link under date in the calender when you have chosen view week, see attached picture, in the earlier version you could go directly to day view, when you hover over the date it shows a ballon and says view day but nothing more is happening when you try to click.
Another issue is also the date in the header where you can chose wich date to show in the calender. Depending on language it changes how it shows. We are using the MRBS in English, Swedish and Finnish and want this date to show in Finnish format 24.2.2017.

Best Regards Kent

Reported by: *anonymous

Original Ticket: mrbs/support-requests/1135

Attachments: https://sourceforge.net/p/mrbs/support-requests/1135/attachment/View%20day.png

jberanek commented 7 years ago

The View Day problem is a bug in 1.5.0 which has been fixed in the latest version of the code in the default branch which you can download here. Just treat the latest snapshot like a new release. As well as a fix for this problem you'll get lots of other bug fixes and enhancements as well.

On the date format question, do you want the date to show in Finnish format even if you are not using the Finnish language?

Original comment by: campbell-m

jberanek commented 7 years ago

Thanks for this fast answer, yes Finnish dateformat even if we are using English or swedish.

Kent

Original comment by: *anonymous

jberanek commented 7 years ago

You will need to edit the file js/datepicker.js. After line 20 which looks like this:

  $.datepicker.setDefaults({

add the line

    dateFormat: 'd.m.yy',

The only problem is that you will need to remember to reapply this change every time you upgrade to the next release of MRBS. (Putting your code under source control so that you can merge the changes would be ideal).

Original comment by: campbell-m

jberanek commented 7 years ago

Thanks for your advice,

Kent

Original comment by: *anonymous

jberanek commented 7 years ago

Hi, I had to rewrite te config file after updating, blank page after updating, datepicker is now allso as we wanted. Thanks for all help.

Kent

Original comment by: *anonymous

jberanek commented 7 years ago

Good, glad it's working now. Yes, I forgot to say - in MRBS now, when you update you overwrite all files except the config file. That way you won't haver to keep re-applying your config settings.

Original comment by: campbell-m

jberanek commented 7 years ago

I think what Anonymous was alluding to about upgrading to the snapshot is that in this case you can't use your old config file, as it needs:

namespace MRBS

adding at the top of the file.

We should mention that in UPGRADE.

Original comment by: jberanek

jberanek commented 7 years ago

I'm not sure that's true. I don't think namespaces apply to variables, which is all the config file contains, and so the namespace statement makes no difference. I think when I namespaced MRBS I just went and put a namespace statement at the top of every file. I've just done a quick test and it seems to work OK without the namespace statement, though I'd suggest we leave it in there.

What might have been the problem for Anonymous was the old style of config file which included language.inc.

Original comment by: campbell-m

jberanek commented 7 years ago

Hmm, you're right Campbell...I was sure I'd had an issue with my config.inc.php after the namespace change was added, but it must have been something else...

Original comment by: jberanek