meeting-room-booking-system / mrbs-code

MRBS application code
Other
124 stars 61 forks source link

Add persons to created event in Outlook #3203

Open jberanek opened 2 years ago

jberanek commented 2 years ago

Hello Team,

just a quick question regarding $mail_settings['organizer']: Would it be possible that this variable can automatically hold the mail address of the person who is doing the booking?

Then: When a booking has been created a mail is being send to the person who has made the booking. Also an entry in the Outlook calendar is created. This is working really good. But how is possible to invite further persons to this event using the wizard in Outlook? When I open the event I am not able to add persons to this event. The buttons for doing this are not visible.

If there is a way to achieve that it would be nearly perfect. :)

Many thanks in advance, best regards

Thomas

Reported by: gonzo1969

Original Ticket: mrbs/support-requests/2518

jberanek commented 2 years ago

I will take a look at this when I get a chance over the week or two. However I suspect it won't be simple as I know that it would cause problems with some email clients, eg IBM Domino: see the comments in systemdefaults.inc.php below:

// The address to be used for the ORGANIZER in an iCalendar event.   Do not make
// this email address the same as the admin email address or the recipients
// email address because on some mail systems, eg IBM Domino, the iCalendar email
// notification is silently discarded if the organizer's email address is the same
// as the recipient's.  On other systems you may get a "Meeting not found" message.
$mail_settings['organizer'] = 'mrbs@your.org';

Original comment by: campbell-m

jberanek commented 2 years ago

Hi Campbell,

... yes, I have seen the documentation. When I enter my mail address and create a booking it looks good so far. But unfortunately I am not be able to add more participants to the event in Outlook when doing so.

For me it is more important to be able to add participants to the booking in Outlook.

Best regards Thomas

Original comment by: gonzo1969

jberanek commented 1 year ago

Hello, Is there any news about this? I am also interested in making the booker also the organizer. Best regards, Xavier

Original comment by: *anonymous

jberanek commented 1 year ago

To make the booker the organizer, edit functions_ical,inc and change the line (roughly 851)

$organizer = PHPMailer::parseAddresses($mail_settings['organizer'], true, get_mail_charset())[0];

to

  $creator = auth()->getUser($data['create_by']);
  if (isset($creator))
  {
    $creator_mailbox = $creator->mailbox();
  }
  if (isset($creator_mailbox))
  {
    $organizer = PHPMailer::parseAddresses($creator->mailbox(), true, get_mail_charset())[0];
  }
  else
  {
    $organizer = PHPMailer::parseAddresses($mail_settings['organizer'], true, get_mail_charset())[0];
  }

However, as stated above, this doesn't seem to work with Outlook as stated above. See this post for more details. I have tried the suggestion of changing the method from "REQUEST" to "PUBLISH" but that didn't work for me.

Perhaps what you really want is the ability to add more participants when making the booking in MRBS?

Original comment by: campbell-m