meeting-room-booking-system / mrbs-code

MRBS application code
Other
108 stars 56 forks source link

booking becomes longer than defind 1 hour becomes 1.25 #510

Open jberanek opened 10 years ago

jberanek commented 10 years ago

latest mrbs wamp install

i have time slots in 15 min intervals

if i book a room for an hour the duration becomes 1.25 in the confirmation page i need the end time to be the defind end time.

can i change something to make the duration display the defined time. our staff would be confused so this is the only thing stopping the installation from going live.

Reported by: *anonymous

Original Ticket: mrbs/bugs/302

jberanek commented 10 years ago

I can't reproduce this I'm afraid. Can you describe the steps to reproduce this a bit more? How are you selecting an hour - by drag selecting on the day/week page or by using the select box on the edit_entry.php form? What do you mean by the confirmation page?

Also can you give your MRBS version (I know you said latest, but that could mean lots of things) and also PHP and MySQL/PostgreSQL versions? (Information available on the Help page).

Campbell

Original comment by: campbell-m

jberanek commented 10 years ago

not at work right now but downloaded mrbs 2 days ago i use the drag and select method

if i select 8.00 until 9.00 in the booking confirmation page shows a duration of 1.25 hours

the only thing i changed was the end time to 18:00 and the interval from 30 down to 15 in the area settings

Original comment by: *anonymous

jberanek commented 10 years ago

confirmation page

when you select your booking time by dragging over the time slots you then see a page confirming your booking

time location you click the button at the bottom to save the booking.

i will post screen shots tomorrow.

Original comment by: *anonymous

jberanek commented 10 years ago

wamp downloaded 2 days ago so would say latest version

will post exact details tomorrow am

thanks for the quick reply

Original comment by: *anonymous

jberanek commented 10 years ago

Apache : 2.4.9 MySQL : 5.6.17 PHP : 5.5.12 

Original comment by: *anonymous

jberanek commented 10 years ago

The other interesting things to know would be (a) the browser and version you are seeing the problem with and (b) whether you have the slot times on the y-axis (the default) or along the x-axis.

Campbell

Original comment by: campbell-m

jberanek commented 10 years ago

windows 7 ie9 all settings default will try in google chrome tomorrow

i wont waste your time tonight i will post screen shots tomorrow

do you need to see any of the config files the areas and rooms were imported from your sample data and edited if that makes any difference

thankyou again for your time

Original comment by: *anonymous

jberanek commented 10 years ago

OK - I look forward to seeing the screen shots. Don't need the config file at the moment.

Original comment by: campbell-m

jberanek commented 10 years ago

Here are the details of my issue, hope the pdf has all the info you require

Original comment by: *anonymous

Attachments: https://sourceforge.net/p/mrbs/bugs/_discuss/thread/fa4eb3fb/8251/attachment/C%3A%5CUsers%5Cbourked%5CDesktop%5CMrbs%20time%20slot%20issue.pdf

jberanek commented 10 years ago

I think the issue is that when i select 7-00 till 8-00

8-00 becomes the start of the last 15min block hence the 1.15 duration i need the 8-00 time to be the end of the booking and not the start of the last 15 min block

i would like the the bookings to be displayed to the time defind and not the begging of the slot before this is a visual aid and not a bug in the project.

hope this comes across correctly

Original comment by: *anonymous

jberanek commented 10 years ago

Yes, you have selected five slots (highlighted in pink) so it has given you 1.25 hours. The times represent the start times of the slots.

Campbell

Original comment by: *anonymous

jberanek commented 10 years ago

Can this be changed as i understand that it is not a bug but by design

after looking at my system it is correct but sometime personally i ignore the slots and select by times 7-00 till 8-00

if nothing can be done i will just ensure my training guide represents this understanding

thank you Campbell

Original comment by: *anonymous

jberanek commented 10 years ago

or could i turn off the drag and book facility

Original comment by: *anonymous

jberanek commented 10 years ago

I'd be happy to change it if you could suggest a user interface that makes sense. I'll tell you how to disable drag and select later today or tomorrow.

Campbell

Original comment by: *anonymous

jberanek commented 10 years ago

your a star Campbell

Original comment by: *anonymous

jberanek commented 10 years ago

I suppose one solution would be to have the times displayed as "0800-0815" etc. instead of "0800" etc. Would that work? It would take up a little more space on the screen but might be clearer. Could be made a configurable option for those who don't want it.

Campbell

Original comment by: campbell-m

jberanek commented 10 years ago

If in the short term you want to disable the drag and select booking then the easiest thing to do is to add a return at line 778 in the file js/resizable.js.php. In other words the code would now look like this:

          <?php
          // Turn all the empty cells where a new multi-cell selection
          // can be created by dragging the mouse
          ?>     
          table.find('td.new').each(function() {
              return;  // add this line to disable drag and select
              $(this).find('a').click(function(event) {
                  event.preventDefault();
                });
              $(this).mousedown(function(event) {
                  event.preventDefault();
                  downHandler(event);
                  $(document).bind('mousemove', moveHandler);
                  $(document).bind('mouseup', upHandler);
                });
            });

I don't think it's worth making this into a configurable option as I can't see that it would be necessary if the time slot labelling was clearer.

Campbell

Original comment by: campbell-m

jberanek commented 10 years ago

Thanks campbell for taking the time to help

First class project

Original comment by: *anonymous

jberanek commented 10 years ago

Do you have a view on labelling the slots as 0800-0815, 0815-0830 etc. instead of 0800, 0815, etc.?

Campbell

Original comment by: campbell-m

jberanek commented 10 years ago

you can close this now cambell as the staff need to get a grip and understand how calendars work.

Thanks for your help

Original comment by: *anonymous