search

meetinghouse / cms

Laravel CMS
0 stars 3 forks source link

Light Theme: Leave Submenus expanded when a page clicked #256

Closed KathJohnson closed 7 years ago

KathJohnson commented 8 years ago

I'm moving this into GitHub so I can keep track of it more easily. This request came from Steve Drago at New England Soundproofing on May 11, 2016: So I love the left nav but had one repetitive complaint. When you click on the drop down for the left nav and pick a option it will bring you to that page but closes the left nav. The complaint is the customer/user doesn’t remember what drop down they picked because it closes. Is there a way to keep it open when it navigates to the next page?

For example, If i click on “Types of rooms” and it drops down and you click “commercial Soundproofing” it brings you to that page. BUT when you on that page, the drop down isn’t expanded and the client doesn’t know where he picked. It would be nice to have that still open and the blue to show where they went to.

John Bozaan made this comment May 18, 2016: On this site: newenglandsoundproofing.corbettresearchgroup.com which I think went live today, although their old URL doesn’t seem to be loading. In the below email, Steve is asking for the active sub-menu to be visible, meaning the sub-menu would remain open on page load showing the active page in the sub-menu. I can do this with a client side script, but I’m wondering if it’s possible to do this server side. A class, “in”, and some pseudo-classes need to get added if there’s an active sub-nav item: image Sounds like a client side task to me, but thought I’d ask. Thoughts?

Then John Bozaan further commented May 18, 2016: That wouldn’t take too long, maybe 1.5 hours? But I need to do some testing to see if it will work and not mess with the Bootstrap script that controls it, could conflict with the functionality. Did Sudhir respond on this? I didn’t see anything.

@1sp, do you have any thoughts on how long this might take for you to make this work across the board?

1sp commented 8 years ago

As per the bootstrap documentation we would need to play with two classes here based on whether the current url's menu item has a parent or not(as shown in screen below). Fix should take around an hour or so to implement. expanded collapsed

jboz62 commented 8 years ago

Katherine and I both agree, this is better to do server side as it will be available for all the sites. Let’s wait for Katherine’s go ahead on this. Thank you for the input, Sudhir.

On May 18, 2016, at 2:17 PM, Sudhir notifications@github.com wrote:

As per the bootstrap documentation we would need to play with two classes here based on whether the current url's menu item has a parent or not(as shown in screen below). Should take around an hour or so. https://cloud.githubusercontent.com/assets/60359/15370055/d467d046-1d52-11e6-9d9f-646106044d05.png https://cloud.githubusercontent.com/assets/60359/15370056/d4692518-1d52-11e6-99e3-0358065dcc85.png — You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/meetinghouse/cms/issues/256#issuecomment-220113419

jboz62 commented 8 years ago

Katherine, what’s going on with the DNS setup on this site? Their main domain is still dead: newenglandsoundproofing.com http://newenglandsoundproofing.com/ It doesn’t load the new site?

On May 18, 2016, at 2:17 PM, Sudhir notifications@github.com wrote:

As per the bootstrap documentation we would need to play with two classes here based on whether the current url's menu item has a parent or not(as shown in screen below). Should take around an hour or so. https://cloud.githubusercontent.com/assets/60359/15370055/d467d046-1d52-11e6-9d9f-646106044d05.png https://cloud.githubusercontent.com/assets/60359/15370056/d4692518-1d52-11e6-99e3-0358065dcc85.png — You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/meetinghouse/cms/issues/256#issuecomment-220113419

meetinghouse commented 8 years ago

This site isn't actually launched. It was delayed, I think just because he is busy and doesn't have much time this week to review. Sorry I didn't notice your comments about that earlier. Their current site at newenglandsoundproofing.com is live and looks fine from where I'm sitting. It's on the Servint server, not the Digital Ocean server.

Client would like to launch next week. Tuesday night is the target right now.

jboz62 commented 8 years ago

Yes, I looked at it earlier, it does seem to be working now, probably a server glitch when I was trying to view it before.

Speaking of server glitches, it looks like the cPanel for the RTD site is working again too.

On May 19, 2016, at 12:50 PM, John M. Corbett notifications@github.com wrote:

This site isn't actually launched. It was delayed, I think just because he is busy and doesn't have much time this week to review. Sorry I didn't notice your comments about that earlier. Their current site at newenglandsoundproofing.com is live and looks fine from where I'm sitting. It's on the Servint server, not the Digital Ocean server.

Client would like to launch next week. Tuesday night is the target right now. — You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/meetinghouse/cms/issues/256#issuecomment-220384947

jboz62 commented 8 years ago

@vivek-chaudhari Vivek, this is a request from one of the clients, but is also something that should probably be part of the menu function. Can you review this issue and let me know if you can do this and how long it would take? Thanks! John

vivek-chaudhari commented 8 years ago

@jboz62 John, Client needs dropdown in expanded mode when they are on expand menu item, right? I have reviewed this and it will take 1-2 hours approx.

jboz62 commented 8 years ago

Ok, that’s sounds good, Vivek. Please proceed with the changes, but don’t commit anything until I get this Github issue resolved.

Thanks, John

On Oct 3, 2016, at 8:36 AM, Vivek Chaudhari notifications@github.com wrote:

@jboz62 https://github.com/jboz62 John, Client needs dropdown in expanded mode when they are on expand menu item, right? I have reviewed this and it will take 1-2 hours approx.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meetinghouse/cms/issues/256#issuecomment-251094843, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMf8BWYEQW0qu7uWdDdmQG3NYqrNFzgks5qwPa2gaJpZM4IhjaC.

vivek-chaudhari commented 8 years ago

@jboz62 We have implemented it as part of Light Theme doing on server side, let me know whenever I want to commit it.

jboz62 commented 8 years ago

Ok, thanks Vivek. I’ll take a look.

On Oct 4, 2016, at 3:14 AM, Vivek Chaudhari notifications@github.com wrote:

@jboz62 https://github.com/jboz62 We have implemented it as part of Light Theme doing on server side, let me know whenever I want to commit it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meetinghouse/cms/issues/256#issuecomment-251311749, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMf8PErGYFMJA668ymGGJ1_RA8DZHtuks5qwfzAgaJpZM4IhjaC.

jboz62 commented 7 years ago

Done.