meetinghouse / cms

Laravel CMS
0 stars 3 forks source link

S+H: Read More link on Builder's Notebook page #262

Closed meetinghouse closed 7 years ago

meetinghouse commented 8 years ago

@jboz62

I don't know if this is a css change or needs to be an underlying code base change, but S+H has asked for a "Read More" link to appear on the Builder's Notebook page under each entry so it is clear that there is more to read.

They'd like some white space between the end of the content and the link, and for the link to be distinguishable as a link (they said blue, but perhaps underlined would be more harmonious with the page design). They'd like it to appear in parentheses, and link, of course, to the full blog post page.

jboz62 commented 8 years ago

It’s possible to do this via css, but not the best solution. The problem is, you can add a “read more” in the "Intro Paragraph” excerpt text box to have it show up in the listing, but it also shows up when you navigate to the full page. You would need to hide it on the full page and display it in the listing. It would be best to do that in the code so that it would have the same link that is around each entry in the post listing.

In order to do this client side, we’d need to add the “read more” and use the source button to add a css class to it (like:

Read More

) then I could use a script to display or hide it depending on the URL. Of course, that probably requires a deployment, though.

Since we have a bottleneck going on with deployment, that’s not possible right now.

Is Sudhir looking into how the “builder’s notebook” menu setup works and how to incorporate it into the master repository (blog)? I’m not sure how we can deploy to S+H with all the custom code that seems to be in there. That needs to be figured out before we can do anything with S+H, along with the whole deployment issue in general.

On Jun 1, 2016, at 12:34 PM, John M. Corbett notifications@github.com wrote:

@jboz62 https://github.com/jboz62 I don't know if this is a css change or needs to be an underlying code base change, but S+H has asked for a "Read More" link to appear on the Builder's Notebook page under each entry so it is clear that there is more to read.

They'd like some white space between the end of the content and the link, and for the link to be distinguishable as a link (they said blue, but perhaps underlined would be more harmonious with the page design). They'd like it to appear in parentheses, and link, of course, to the full blog post page.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meetinghouse/cms/issues/262, or mute the thread https://github.com/notifications/unsubscribe/ALMf8IBPtVp8OTC8qfL4pFJbb__eJnOXks5qHbSPgaJpZM4IrvY0.

jboz62 commented 8 years ago

There are a couple nice solutions for this out there, but both would require we either take the code further out of version control, or do this after we fix the menu/blog issue and deploy to S+H.

This might be a good solution for this: http://jedfoster.com/Readmore.js/ Here's another that would work for this: https://codepen.io/maxds/pen/jgeoA/

jboz62 commented 8 years ago

@vivek-chaudhari Vivek, we have a "read more..." feature on the related projects, see here. We need this to also be on the blog page. Can you look at how that was done and let me know if you can add it to the blog? S+H wants this on their "Builder's Notebook" (blog). Please give me a time estimate on this. Thanks, John

jboz62 commented 8 years ago

@vivek-chaudhari It looks like that code for the "read more" is in: cms/app/views/shared/projects_teasers.blade.php

Hope that helps.

jboz62 commented 8 years ago

@vivek-chaudhari Vivek, here are a couple images to show you what we need:

This is in the post edit/create view: blog-post

The front end blog: blog-listing

vivek-chaudhari commented 8 years ago

@jboz62 we can easily achieve this, no need to use css or any other external js library. we can do this in php. I will take 1-1.5 hours to do this.

jboz62 commented 8 years ago

@vivek-chaudhari Yes, those were old notes, we don't need css or js, just in the code base. Please execute this change. Thanks.

vivek-chaudhari commented 8 years ago

@jboz62 I will proceed for changes and give you update soon.

vivek-chaudhari commented 8 years ago

@jboz62 Now please review this.

jboz62 commented 8 years ago

@vivek-chaudhari I've been out sick, Vivek, still recovering but will begin getting back to work. Sorry for the delay.

vivek-chaudhari commented 8 years ago

@jboz62 It's okay John, Hope you will get well soon.Whenever we need to go on then let me inform.

jboz62 commented 7 years ago

@vivek-chaudhari Vivek, the "read more" looks good, but it's in the wrong place. Please review the screenshot below for the proper placement and revise. Thank you. 9767d7a6-9712-11e6-98d5-fe5b7a2203fb read-more2

vivek-chaudhari commented 7 years ago

@jboz62 Okay john I can do this.

vivek-chaudhari commented 7 years ago

@jboz62 Now review this.

jboz62 commented 7 years ago

Finished.