meetrevision / playbook

A lightweight, stable, and performance-focused customized version of Windows that enhances privacy and compatibility
https://www.revi.cc
Other
944 stars 74 forks source link

[BUG]: Intel TSX significantly reduces performance on AMD CPU #100

Closed PACHAKUTlQ closed 6 months ago

PACHAKUTlQ commented 6 months ago

Describe the bug

Revi playbook enables Intel TSX feature by default. In Revision tool, it is described as:

Add hardware transactional memory support, which helps speed up the execution of multithreaded software at the cost of security

However, enabling Intel TSX seems to significantly reduce performance on AMD CPU. For a simple C program that count prime numbers under 100000000, it takes 73 seconds to run with Intel TSX on, while 54 seconds with Intel TSX off. (Similar results when testing on Arch WSL using the same program)

Steps to reproduce

  1. Install Windows 11 on a laptop with AMD CPU
  2. Run AME Wizard with Revi playbook, default configurations
  3. Run a CPU performance testing program
  4. Disable Intel TSX in Performance bar in Revision tool (auto-installed by the playbook)
  5. Run the performance testing program again to find improved performance

Expected behavior

Revi playbook can detect if running on AMD CPU, and disable Intel TSX automatically.

Environment

Additional information

Have you searched for similar issues?

Lyceris-chan commented 6 months ago

add it to revert modifications as well to fix pre patched systems?