search

meetrevision / playbook

A lightweight, stable, and performance-focused customized version of Windows that enhances privacy and compatibility
https://www.revi.cc
Other
936 stars 73 forks source link

[BUG]: Lid actions #119

Closed Edgars-Cirulis closed 4 months ago

Edgars-Cirulis commented 4 months ago

Describe the bug

The commit https://github.com/meetrevision/playbook/commit/507fd54e819eae67b7e5e67ae54abb51229c2735 did not fix issue https://github.com/meetrevision/playbook/issues/105. I saved the lid actions that were working on apply, and while reapplying the playbook, it saved the layout settings I had changed, but I need to reapply them to make it work.

Steps to reproduce

  1. Set LID actions in power settings to "Do nothing," save it, and it works.
  2. Reapply the playbook.
  3. LID action settings were saved, but they don't work; it goes to sleep mode. So, I need to reapply the settings from "Do Nothing" to "Sleep" and again to "Do Nothing."

Expected behavior

I expected that the PC wouldn't go to sleep with lid closed after reapplying the playbook.

Environment

Additional information

No response

Have you searched for similar issues?

melo936 commented 4 months ago

The most recent fix works as intended. After the release of 23.12, during the testing phase, the playbook was designed to reset, hide, or delete every power plan except for Revision's.

Resetting Revision's power plan is mandatory when applying the playbook, and providing toggle or revert options would lead to unexpected performance behaviors because hidden power plan settings change periodically.

Edgars-Cirulis commented 4 months ago

Dunno, I'll make a video about it to prove that it doesn't fix. It still makes computer in sleep after replying playbook even tho it says lid actions: do nothing. If I replied the same value from from do nothing to sleep then do nothing it works again.