meetrevision / revision-tool

A tool to personalize ReviOS to your needs
GNU General Public License v3.0
298 stars 39 forks source link

RevisionTool crashes if the application "LocalSend" is running in the background. #86

Closed albryx closed 1 month ago

albryx commented 5 months ago

Description: RevisionTool refuses to launch if "localsend_app.exe" is running, a cmd window will instead show for 0.1 seconds just to close itself. However, if we kill the process "localsend_app.exe", RevisionTool will boot up.

Steps to reproduce the behavior:

  1. Apply ReviOS playbook "Revi-PB-24.06"
  2. Download localsend: https://github.com/localsend/localsend/releases (Latest Version - 1.14.0)
  3. Have localsend run in the background.
  4. Try to launch RevisionTool.
  5. Crash should happen here.

Expected behavior: Both applications should run fine together.

Desktop:

Additional Context: As a note, I don't think this happened with previous versions of the tool.

melo936 commented 1 month ago

Hi, could you try this out? I'm working on refactoring a lot of things, and based on my testing, this issue no longer occurs.

https://github.com/meetrevision/revision-tool/releases/download/1.99.9/RevisionTool-Setup.exe

albryx commented 1 month ago

Hello, I can confirm the version you provided (2.0.0) now works fine with localsend. Thank you for the bug fix.