search

meetthakkar88 / accord

Automatically exported from code.google.com/p/accord
0 stars 0 forks source link

Match grouping could be generic #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I need to group triangles and other structures, so I am proposing that 
MatchGrouping class be generic.

(you can erase Triangle group matching or convert it, as you wish)

I have made necessary changes.
I hope you will accept it.

Original issue reported on code.google.com by darko.ju...@gmail.com on 12 Jun 2013 at 5:01

GoogleCodeExporter commented 9 years ago 
C# class file attached.

Original comment by darko.ju...@gmail.com on 12 Jun 2013 at 5:02

Attachments:

GoogleCodeExporter commented 9 years ago 
New version: (file attached)

Original comment by darko.ju...@gmail.com on 18 Jun 2013 at 3:28

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks Darko! Thanks for the many contributions, as always. I will prepare a 
review for them by the weekend.

Original comment by cesarso...@gmail.com on 18 Jun 2013 at 4:24

GoogleCodeExporter commented 9 years ago 
Hi Darko,

I was thinking about making the near and average functions virtual instead of 
delegates, so they could be implemented by inheritance. I see that you have 
already provided specialized classes for rectangles and triangles, so I think 
this could also work. Do you have any use case in which you think this would 
not suffice?

Thanks again for the contribution!

Regards,
Cesar

Original comment by cesarso...@gmail.com on 22 Jun 2013 at 6:24

GoogleCodeExporter commented 9 years ago 
No, I don't have.
I think that inheritance will be just fine.

You are welcome.

Original comment by darko.ju...@gmail.com on 23 Jun 2013 at 10:05

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r605.

Original comment by cesarso...@gmail.com on 27 Jul 2013 at 6:31