meetup / rules_openapi

🍃 bazel rules for generating code from openapi specifications
MIT License
52 stars 25 forks source link

support both openapi and swaager #40

Closed yishanhe closed 3 years ago

yishanhe commented 3 years ago
yishanhe commented 3 years ago

This is related to addressing issue #27 , instead of deprecating, as swagger codegen is alive as well. might just support both.

softprops commented 3 years ago

@yishanhe thanks for pull.

Would you be able to add a test case covering your changes to make sure these changes have the impact you're looking for and not regress the current rules?

You can find the current test runner here

yishanhe commented 3 years ago

@softprops agree with the test coverage requirements. when I looked at the existing tests, it is really trivial, current test is more like testing reproducibility (not functional correctness). any suggestion on tests that I can add? Thanks.

softprops commented 3 years ago

It may make sense to create a variation that test that uses the openapi provider

softprops commented 3 years ago

Thanks @yishanhe!