search

meetup / rules_openapi

🍃 bazel rules for generating code from openapi specifications
MIT License
52 stars 25 forks source link

[openapi] Add support for openapi-generator 5.0.0 #49

Closed ex0ns closed 2 years ago

ex0ns commented 3 years ago

The CLI of openapi generator changed a bit with the 5.0.0 release. As mention here, the global property must now be provided using the --global-property flag instead of -D.

Documentation was updated as well as some tests with specific openapi-cli versions.

The parsing of the version from the jar might not be resilient (if the version number contains a - for instance) but regular expression are not available in Starlark.

The Bazel compatibility matrix will probably need an update once this commit is merged.

chenrui333 commented 3 years ago

@ex0ns sorry about the delay, I will merge this tonight.

jimsong commented 2 years ago

@chenrui333 I am interested in using this. Are there plans on including this change at some point?

jimsong commented 2 years ago

Thanks @softprops!