search

mefechoel / svelte-navigator

Simple, accessible routing for Svelte
Other
509 stars 39 forks source link

Fix for issue #69 #70

Closed Chunxei closed 2 years ago

Chunxei commented 2 years ago

Fixes the issue where imported svelte components cause the editor to throw the following error:

“Argument of type 'typeof Router' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'”

mefechoel commented 2 years ago

Thanks for the PR! The formatting doesn's seem to be quite right though... The checks are failing a the moment. I'll have a look if I can adapt your changes and maybe get rid of the LocalComponent entirely, as it was kind of a hack to get the type checking working when ts support was very fresh in svelte.

Chunxei commented 2 years ago

Alright thanks. Looking forward to updates on the issue. Super helpful library 👍🏾