search

meffie / molecule-proxmox

Molecule driver for Proxmox VE
MIT License
36 stars 8 forks source link

Add option to put created vm into a pool #13

Closed IamLunchbox closed 6 months ago

IamLunchbox commented 7 months ago

This PR adds the option pool into the create.yml file. Creating a vm with molecule then tries to add this vm automatically into the given pool. The other steps (prepare, destroy) only use the vmid to determine the virtual machine and therefore don't rely on the pooloption.

The pool option can be found here: https://docs.ansible.com/ansible/latest/collections/community/general/proxmox_kvm_module.html#parameter-pool

meffie commented 7 months ago

Hello Thanks for the pull request!

Some questions in the code review.

I see there is some churn here in the commits. Would you be willing to do a git rebase to squash out the reverts and do a force push to this PR?

IamLunchbox commented 7 months ago

I will rebase and force push. I accidentially changed the main branch - I expected github to let the PR "as is". I will fix this right away

meffie commented 6 months ago

I will rebase and force push. I accidentially changed the main branch - I expected github to let the PR "as is". I will fix this right away

Thank you. Well done.

meffie commented 6 months ago

Oops. I should have run the unit tests before hitting the merge button. We forgot to remove the d() after removing the referenced "pool" variable. Pushing a fix to the main branch as a followup.

meffie commented 6 months ago

I pushed the followup commit to the main branch:

a6520d3 Remove incorrect default() in create playbook