meffie / molecule-proxmox

Molecule driver for Proxmox VE
MIT License
35 stars 9 forks source link

missing some useful parameter #16

Open bitchecker opened 1 month ago

bitchecker commented 1 month ago

Hi, in driver section I see that is possible to configure user for API and SSH but, IMHO, some parameters are missing.

I think that some hardened network configs should require two other parameters:

IamLunchbox commented 1 month ago

I suppose a pull request is most certainly welcome to make these requirements possible. Michael did check on mine quite fast, so it should not take too long to get it merged.

ssh_port maybe need to be templated here and the value should be - in my opinion - derived from a platform value.

api_port is currently implicitly 8006 - the community.general.proxmox_kvm documentation mentioned, that this value may be derived from the environment variable PROXMOX_PORT - so this could fit your needs in the meantime. If you want to prepare a pull request, the option must be added to all api calls in create.yml and destroy.yml in src/molecule_proxmox/playbooks/.

meffie commented 1 month ago

Hmm, yes it seems we could add these to override the default ports. I try to avoid adding configuration unless someone actually needs it, but alternate port numbers seems ok.