mega12345mega / NBT-Editor

Edit items, blocks, and entities in-game.
MIT License
31 stars 9 forks source link

ClientChest Improvements #60

Closed KadTheHunter closed 5 months ago

KadTheHunter commented 1 year ago

I've thought of a few improvements for the ClientChest:

mega12345mega commented 1 year ago

These sound great! They shouldn't be too difficult to implement. As a combination of 1 and 2, /chest <name> would also work (and should suggest the different names as you are typing).

Similar to the book editor, I could use the Page Up and Page Down buttons. I may add a config option for using arrow keys for users with smaller keyboards.

This does lead into a more folder structure; when you start having lots of weapons in the "weapons" page, you might want a "weapons/swords", "weapons/bows", etc. However I don't know a good way to add this in the gui. It is probably too extreme (at least for now).

In the meantime, named containers work great for sorting things (and they can be nested!). The main disadvantage is that they usually have 27 slots instead of 54. You can use the keybind to open the containers without bringing them out of the chest.

KadTheHunter commented 6 months ago

Just tried the dev build, and it works great! Everything is as I hoped. Only things I noticed is:

Regardless, amazing work, and thank you so much for adding this :D

mega12345mega commented 6 months ago

When writing the page keybind code, I was thinking of Page Down as a sort of next page, since you would typically type it when you want to see the next piece of text on a website. Do you think this should be configurable?

I've now changed it so that when you type a duplicate name it highlights it in red (just like when entering an invalid value in the item factories), but hitting Enter causes it to override.

KadTheHunter commented 6 months ago

When writing the page keybind code, I was thinking of Page Down as a sort of next page, since you would typically type it when you want to see the next piece of text on a website. Do you think this should be configurable?

I was thinking of it more as a Forward/Backward, where Page Up would increase the page number and Page Down decreases it. Probably would be best if the keybind was configurable, but now that I know what you were going for it makes more sense.

I've now changed it so that when you type a duplicate name it highlights it in red (just like when entering an invalid value in the item factories), but hitting Enter causes it to override.

Just tested it, works perfect, thanks!

mega12345mega commented 5 months ago

I've now released this in v1.13.0!