[IMPORTANT BUG] This mod spams the text log every millisecond, resulting in an extremely huge file (over 20GBs)

mega12345mega / NBT-Editor

Edit items, blocks, and entities in-game.

MIT License

49 stars 16 forks source link

[IMPORTANT BUG] This mod spams the text log every millisecond, resulting in an extremely huge file (over 20GBs) #89

Closed Sul4urx closed 3 months ago

Sul4urx commented 7 months ago

This mod spams the following text about 7500 times per second in .minecraft/logs/latest.log: (There is more that is spams as well)

[<time>] [NBTEditor/Async/HeadRefresh/Auto/ERROR]: Failed to fetch heads (no-cache) | Stack Trace:
[<time>] [NBTEditor/Async/HeadRefresh/Auto/ERROR]: java.net.UnknownHostException: minecraft-heads.com
[<time>] [NBTEditor/Async/HeadRefresh/Auto/INFO]: Attempting fallback provider for: alphabet
[<time>] [NBTEditor/Async/HeadRefresh/Auto/ERROR]: Failed to fetch heads for alphabet! (OF)
[<time>] [NBTEditor/Async/HeadRefresh/Auto/ERROR]: java.net.UnknownHostException: heads.pages.dev
[<time>] [NBTEditor/Async/HeadRefresh/Auto/ERROR]: Failed to update database! Check above for any errors.

When it does that, It creates an extremely huge file (it should make the log file over 20 GBs for each hour of playing minecraft).

mega12345mega commented 7 months ago

Obviously a timeout should be added when re-trying, but since this also relates to an issue that used to happen more often, did you happen to be offline when running the mod? The main head provider, minecraft-heads.com, seemed to frequently go offline. That's why there is now a fallback (heads.pages.dev), so I haven't seen this error in a while. I wonder if both went down at the same time, or if you were simply not connected to the internet.

Sul4urx commented 6 months ago

Obviously a timeout should be added when re-trying, but since this also relates to an issue that used to happen more often, did you happen to be offline when running the mod? The main head provider, minecraft-heads.com, seemed to frequently go offline. That's why there is now a fallback (heads.pages.dev), so I haven't seen this error in a while. I wonder if both went down at the same time, or if you were simply not connected to the internet.

I have of course turned on airplane mode, so that means I didn't have an internet connection. But either way this should not be spammed and only be warned upon loading the game, not every millisecond.

mega12345mega commented 4 months ago

A dev build with a fix for this has been available for a while now, I just had forgotten to label the issue

Sul4urx commented 3 months ago

A dev build with a fix for this has been available for a while now, I just had forgotten to label the issue

A dev build? Wait isn't fixing this problem just like changing a few lines of code?

mega12345mega commented 3 months ago

It is - basically, each update consists of many changes, and I "publish" each change on Github before releasing all of them at once officially. Dev builds don't typically work on versions of Minecraft before the last supported version (so right now, dev builds only support 1.20.4). Getting it working on 1.17 involves more changes also published to Github. All of this takes place on the dev branch, before getting merged into main once I decide the update is ready. (Think of "dev builds" like Minecraft snapshots.)

mega12345mega commented 3 months ago

I've now fixed this in v2.0.0!