megabyte-labs / install.doctor

A glorious combination of application / theme settings and a performant cross-platform, desktop-oriented software suite.
https://megabyte.space
Other
85 stars 17 forks source link

Configure clamav on MacOS #133

Closed enggnr closed 6 months ago

enggnr commented 7 months ago
github-actions[bot] commented 7 months ago

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro ### CodeRabbit Pro If you like this project, please support us by purchasing the [Pro version](https://coderabbit.ai). The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.
ProfessorManhattan commented 7 months ago

Hey @enggnr -- can you please resolve the merge conflicts on this and nix the installdoctor branding on the file names? The files should be short and concise.

For example, we should not use /var/log/installdoctor and instead use /var/log/clamav instead:

sudo mkdir -p /var/log/installdoctor
        sudo chown $USER /var/log/installdoctor
        sudo cp -f "$HOME/.local/etc/clamav/installdoctor.clamdscan.plist.tmpl" /Library/LaunchDaemons/installdoctor.clamdscan.plist
        sudo cp -f "$HOME/.local/etc/clamav/installdoctor.freshclam.plist.tmpl" /Library/LaunchDaemons/installdoctor.freshclam.plist
        sudo launchctl load -w /Library/LaunchDaemons/installdoctor.clamdscan.plist
        sudo launchctl load -w /Library/LaunchDaemons/installdoctor.freshclam.plist
enggnr commented 7 months ago

@ProfessorManhattan, comments address. Please review.

ProfessorManhattan commented 6 months ago

Added this one manually... thanks!