megabyte-labs / install.doctor

A glorious combination of application / theme settings and a performant cross-platform, desktop-oriented software suite.
https://megabyte.space
Other
85 stars 17 forks source link

Dynamic gitlab runner registration #137

Open enggnr opened 7 months ago

enggnr commented 7 months ago
github-actions[bot] commented 7 months ago

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro ### CodeRabbit Pro If you like this project, please support us by purchasing the [Pro version](https://coderabbit.ai). The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.
ProfessorManhattan commented 6 months ago

Hey @enggnr --- is this ready to be merged? What issue does it address?

enggnr commented 6 months ago

@ProfessorManhattan, a token was manually added to the secrets to configure Gitlab runner. It was using the now deprecated method of registering runners. This change needs just the Gitlab API token (with right permissions of course) to register a runner at the Group level. It also uses the new method of registering runners.