search

megabyte-labs / task-dash

A gorgeous TUI menu for go-task/task
https://megabyte.space
Other
4 stars 1 forks source link

is this going upstream ? #1

Open gedw99 opened 1 year ago

gedw99 commented 1 year ago

💡 Feature/Idea

Hey @ProfessorManhattan

is this going upstream ? TUI seems like a nice feature :)

saw discussion here: https://github.com/go-task/task/discussions/700

:thumbsup: Can you contribute?

No response

ProfessorManhattan commented 1 year ago

💡 Feature/Idea

Hey @ProfessorManhattan

is this going upstream ? TUI seems like a nice feature :)

saw discussion here: https://github.com/go-task/task/discussions/700

:thumbsup: Can you contribute?

_No res

@gedw99 I funded this project awhile ago and haven't gotten around to testing it. It'd be cool to have it merged upstream but it's missing a key feature - search. Are you a Go programmer / have you tried running this?

Looks like the search feature kinda works, you can filter the list but I was hoping for it to search through the descriptions and possibly summaries as well.

gedw99 commented 1 year ago

Hey @ProfessorManhattan

I tested it just now.

Search ?? If you can explain what you mean i can have a look.

@ProfessorManhattan you can grab me here: https://github.com/gedw99

ProfessorManhattan commented 1 year ago

I'll take a look later and show you what I mean. I was hoping to have it filter the list if you add a search string but I suppose this might be functional enough to propose as a POC to the task project maintainers

gedw99 commented 1 year ago

Ok understand you…

Agree with you . better to just get something upstream and then iterate.

ProfessorManhattan commented 1 year ago

Hey @gedw99 -- I just tested it and it looks like it's working... before merging it, I imagine we should remove the features that are not working (or add them in) like the tabs at the top. Also, I think we should add the command help menu items that are missing like the fact that you need to press tab to go through the tabs and press R to launch the task (which I'd like binded to return in conjuction --- perhaps R could also be used but I think pressing Enter is more intuitive for most).

Here's a video I made demonstrating the feature and describing what I had imagined for this project: https://www.youtube.com/watch?v=JrXFwbRUNIY

I originally had another developer work on this project and added a bunch of other features. Some documentation on the other features as well as the source code is available here: https://github.com/megabyte-labs/bodega

gedw99 commented 1 year ago

nice . will check the video to get a gist of its flow.

ProfessorManhattan commented 1 year ago

I just posted this issue too which is probably pretty important: https://github.com/megabyte-labs/task-dash/issues/2

I think the issue might stem from fuller Taskfile.yml configurations where includes is being used to reference files in other directories.

ProfessorManhattan commented 1 year ago

Also, just posted a topic here in go-task discussions: https://github.com/go-task/task/discussions/1077

ProfessorManhattan commented 1 year ago

Hey @gedw99 .. would you be able to add any fixes for the issues I mentioned on the other thread? Like CTRL+C causing the process to hang and adding the commands to the bottom part of the menu? If you can do that, I can publish it to for use with Homebrew, Snap, and Docker