search

megaease / easemesh

A service mesh implementation for connecting, control, and observe services in spring-cloud.
https://megaease.com/easemesh
Apache License 2.0
508 stars 61 forks source link

Use default alive probe url & service labels in annotations #62

Closed xxx7xxxx closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #62 (f972a1c) into main (5a23788) will decrease coverage by 0.77%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   69.42%   68.64%   -0.78%     
==========================================
  Files           2        2              
  Lines         242      236       -6     
==========================================
- Hits          168      162       -6     
  Misses         58       58              
  Partials       16       16
Impacted Files Coverage Δ
...rator/pkg/deploymentmodifier/deploymentmodifier.go 69.72% <100.00%> (-0.96%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a23788...f972a1c. Read the comment docs.

zhao-kun commented 3 years ago

Got an error:

Error from server: error when creating "04-api-gateway.yaml": admission webhook "mesh-injector.megaease.com" denied the request: invalid labels
xxx7xxxx commented 3 years ago

What's the value of annotation mesh.megaease.com/service-labels