megaease / easemesh

A service mesh implementation for connecting, control, and observe services in spring-cloud.

https://megaease.com/easemesh

Apache License 2.0

508 stars 61 forks source link

Support Service Instance for emctl #84

Closed xxx7xxxx closed 3 years ago

xxx7xxxx commented 3 years ago

Fix #72

Example:

emctl get serviceinstance
emctl get serviceinstance service-001/id-xxx
emctl delete  serviceinstance service-001/id-xxx

And for the filter feature, it needs to be a global design instead of only for serviceinstance.

zhao-kun commented 3 years ago

The implementation isn't completely fulfilling the requirements in #72. We can temporarily ignore the filter function, but the outputs don't make sense to users. The output must contain the information about the instance's status and label

zhao-kun commented 3 years ago

We needn't support deleting instances as they are automatically maintained by the Easemesh control plane. When an mesh pod terminated, the control plane of the EaseMesh would eliminate its instance information from the registry automatically.

codecov-commenter commented 3 years ago

Codecov Report

Merging #84 (e093869) into main (f3b273d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   65.91%   65.91%           
=======================================
  Files           2        2           
  Lines         267      267           
=======================================
  Hits          176      176           
  Misses         73       73           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3b273d...e093869. Read the comment docs.

xxx7xxxx commented 3 years ago

The output issue fixed.