Codecov Report

Merging #90 (eb1f07f) into main (d0aad1e) will increase coverage by 42.02%. The diff coverage is 81.01%.

@@             Coverage Diff             @@
##             main      #90       +/-   ##
===========================================
+ Coverage   37.06%   79.09%   +42.02%     
===========================================
  Files          20       63       +43     
  Lines        1972     5195     +3223     
===========================================
+ Hits          731     4109     +3378     
+ Misses       1118      845      -273     
- Partials      123      241      +118

Impacted Files	Coverage Δ
emctl/cmd/client/resource/customresource.go	`72.22% <ø> (ø)`
emctl/cmd/client/resource/meta/meta.go	`100.00% <ø> (ø)`
.../cmd/client/command/meshinstall/operator/deploy.go	`46.73% <16.66%> (+46.73%)`	:arrow_up:
emctl/cmd/transformer/generator/generator.go	`46.37% <46.37%> (ø)`
...mctl/cmd/transformer/generator/interface_finder.go	`75.67% <75.67%> (ø)`
...tl/cmd/transformer/generator/listmethod_visitor.go	`81.93% <81.93%> (ø)`
emctl/cmd/transformer/generator/visitor.go	`82.31% <82.31%> (ø)`
...mctl/cmd/transformer/generator/interface_method.go	`85.47% <85.47%> (ø)`
emctl/cmd/client/command/apply/applier.go	`100.00% <100.00%> (ø)`
emctl/cmd/client/command/flags/flags.go	`94.52% <100.00%> (ø)`
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0aad1e...eb1f07f. Read the comment docs.

zhao-kun commented 2 years ago

The PR can be reviewed @xxx7xxxx .

Changes including:

Coverage rate promoted from 37.06% -> 78.86%.
Add meshclient ResourceReactor for testing.
Move TableObject and TableCloumn from printer package to meta object for avoiding the cycle import

zhao-kun commented 2 years ago

All source files of resources' meshclient ( except the controller object of the Easegress and custom resource) are generated.

If a new resource meshclient need to be added, just write an interface source code, and add a package comment.

//go:generate go run github.com/megaease/easemeshctl/cmd/transformer <service type> [<resource=url>...]

Example: https://github.com/zhao-kun/easemesh/blob/emctl-ut/emctl/cmd/client/command/meshclient/ingress.go

The pr is ready to review.

@xxx7xxxx @localvar

megaease / easemesh

Prompting test coverage of the `emctl` #90

Codecov Report