search

megaease / easeprobe

A simple, standalone, and lightweight tool that can do health/status checking, written in Go.
Apache License 2.0
2.18k stars 231 forks source link

Avoid random websocket test failures by waiting for http server to start #474

Closed samanhappy closed 10 months ago

samanhappy commented 10 months ago

There were some random test failures for TestWSPing, as shown here.

These failures should emerged when the test cases began running before the http server was ready.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (707e216) 99.08% compared to head (06a0397) 98.78%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #474 +/- ## ========================================== - Coverage 99.08% 98.78% -0.31% ========================================== Files 82 85 +3 Lines 5820 5863 +43 ========================================== + Hits 5767 5792 +25 - Misses 40 52 +12 - Partials 13 19 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.