search

megaease / easeprobe

A simple, standalone, and lightweight tool that can do health/status checking, written in Go.
Apache License 2.0
2.18k stars 231 forks source link

fix: metric EaseProbe_ping_loss Add by mistake #533

Closed fangpsh closed 5 months ago

fangpsh commented 5 months ago
fangpsh commented 5 months ago

I have found the commit that caused this bug, maybe we should re-review this pull request：

https://github.com/megaease/easeprobe/pull/386/files#diff-2905b6c764234f33b4bf658a5c5e0fa0d82289c07f56455c6ed348e60c296c36L142

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.71%. Comparing base (eef3a25) to head (5460418). Report is 34 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #533 +/- ## ========================================== - Coverage 98.80% 98.71% -0.09% ========================================== Files 85 85 Lines 5867 5858 -9 ========================================== - Hits 5797 5783 -14 - Misses 51 56 +5 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samanhappy commented 5 months ago

Thanks for your contribution. These are indeed mistakes that were introduced in the previous PR.