search

megahertz / electron-log

Simple logging module Electron/Node.js/NW.js application. No dependencies. No complicated configuration.
MIT License
1.3k stars 127 forks source link

Can't compile app with @marshallofsound/webpack-asset-relocator-loader #353

Closed megahertz closed 1 year ago

megahertz commented 1 year ago 
    Sorry to reopen this but we need to use this fork (@marshallofsound/webpack-asset-relocator-loader)  of the vercel  webpack-asset-relocator-loader because with it we can load native modules through electron-forge starter template. Do you have some clue on why this is happening?

To reproduce just create a new electron-forge typescript + webpack app using the template, than substitute @vercel/webpack-asset-relocator-loader with @marshallofsound/webpack-asset-relocator-loader

Thanks!

Originally posted by @dj-fiorex in https://github.com/megahertz/electron-log/discussions/333#discussioncomment-5232248

megahertz commented 1 year ago

Will check on the next week

ianrtracey commented 1 year ago

also running into this

megahertz commented 1 year ago

@marshallofsound/webpack-asset-relocator-loader was updated 4 years ago. Looks like its built-in parser can't parse modern js, that's why it fails. Tried a few other packages and it can't compile it too, eg execa.

I don't think it makes sense to tune electron-log@v5 for an abandoned loader. Anyway, if someone can suggest an easy fix I can consider it.