search

megahertz / electron-log

Simple logging module Electron/Node.js/NW.js application. No dependencies. No complicated configuration.
MIT License
1.27k stars 124 forks source link

Errors when running in ESM #390

Closed Stanzilla closed 5 months ago

Stanzilla commented 6 months ago

Just started moving my app to electron 28 with ESM and getting these errors from electron-log

07:47:45.068 › ReferenceError: __dirname is not defined
    at initializePreload (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:324:88)
    at file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:304:11
    at Object.onAppReady (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:81:7)
    at _Logger.initialize [as initializeFn] (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:301:19)
    at _Logger.initialize (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1393:10)
    at file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:29800:5
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
Unhandled electron-log error ReferenceError: require is not defined
    at Object.readPackageJson (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:940:24)
    at getNameAndVersion (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1047:37)
    at Object.getPathVariables (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1060:26)
    at initializeOnFirstAccess (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1145:21)
    at getFile (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1172:5)
    at transport (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1128:19)
    at _Logger.processMessage (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1432:11)
    at _Logger.logData (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1396:10)
    at <computed> [as warn] (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1358:37)
    at file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:314:16
07:47:45.072 › App starting...
Unhandled electron-log error ReferenceError: require is not defined
    at Object.readPackageJson (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:940:24)
    at getNameAndVersion (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1047:37)
    at Object.getPathVariables (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1060:26)
    at initializeOnFirstAccess (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1145:21)
    at getFile (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1172:5)
    at transport (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1128:19)
    at _Logger.processMessage (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1432:11)
    at _Logger.logData (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1396:10)
    at <computed> [as info] (file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:1358:37)
    at file:///Users/stan/projects/personal/WeakAuras-Companion/dist-electron/main/index.mjs:29801:5
2023-12-30 07:47:45.096 Electron[41484:2802401] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

Repo/branch would be here https://github.com/WeakAuras/WeakAuras-Companion/pull/2257

megahertz commented 6 months ago

I still need to test this lib for the case when it's bundled to ESM. I'm going to fix that in January. In your case, you can move electron-log to normal dependencies as a workaround.

megahertz commented 6 months ago

I tried to add a workaround for Vite. You can try electron-log@5.0.5-beta.2

Stanzilla commented 6 months ago

I tried to add a workaround for Vite. You can try electron-log@5.0.5-beta.2

thanks! looks like no errors so far