megahertz / electron-log

Simple logging module Electron/Node.js/NW.js application. No dependencies. No complicated configuration.
MIT License
1.3k stars 127 forks source link

Setting log level is not working #436

Closed slhck closed 3 weeks ago

slhck commented 4 weeks ago

I am using version 5.1.7 of electron-log.

Here is what's at the top of my main background script:

import log from 'electron-log';

log.transports.file.format = 'FILE [{iso}] [{level}]{scope} {text}';
log.transports.file.level = 'error';

log.transports.console.format = 'CONSOLE [{iso}] [{level}]{scope} {text}';
log.transports.console.level = 'error';

Object.assign(console, log.functions);

console.error('Hello from console.error');
console.warn('Hello from console.warn');
console.log('Hello from console.log');
console.info('Hello from console.info');
console.debug('Hello from console.debug');
console.trace('Hello from console.trace');

What I am expecting:

[1] CONSOLE [2024-09-05T19:21:27.344Z] [error] Hello from console.error
FILE [2024-09-05T19:21:27.344Z] [error] Hello from console.error

What I am getting:

[1] CONSOLE [2024-09-05T19:21:27.344Z] [error] Hello from console.error
[1] CONSOLE [2024-09-05T19:21:27.346Z] [info]  Hello from console.log
[1] CONSOLE [2024-09-05T19:21:27.538Z] [error] Trace: Hello from console.trace
(… trace below)
FILE [2024-09-05T19:21:27.344Z] [error] Hello from console.error
FILE [2024-09-05T19:21:27.346Z] [info]  Hello from console.log
FILE [2024-09-05T19:21:27.538Z] [error] Trace: Hello from console.trace
(… trace below)

Why might that be? Why would warnings not be shown, but regular log is printed?

slhck commented 4 weeks ago

Oh, let me guess the reason: Console.log is not aliased to .info and therefore ignored when filtering by log level by the library. Is that intentional or an oversight?

megahertz commented 3 weeks ago

You're right. Actually, console.log should be mapped to the info level, I just fixed that. As for console.trace, it calls console.error under the hood, that's why it's processed.

slhck commented 3 weeks ago

That's great, thanks for the quick fix!