search

megahertz / electron-simple-publisher

Simple way to publish releases for electron-simple-updater
MIT License
66 stars 25 forks source link

SSH transport fails when using 'password' #10

Closed TimNZ closed 7 years ago

TimNZ commented 7 years ago

Great work for simplifying auto updates, thank you so much. electron-builder and the others are so poorly documented and complex.

Had to change transports/ssh.js. Faulty boolean logic for private key checks when 'password' is specified in publisher.json/options

if (options.usePrivateKey || !options.privateKeyPath || !options.privateKey) {
      // options.privateKeyPath = path.join(os.homedir(), '.ssh', 'id_rsa');
    }
    if (options.privateKeyPath) {
      // options.privateKey = fs.readFileSync(options.privateKeyPath, 'utf-8');
    }
TimNZ commented 7 years ago

Thanks!

megahertz commented 7 years ago

Thank you for the report. It was very ugly bug.